Should you worry about code reviewing someone more experienced than you?

By Dan Bader — Get free updates of new posts here.

Doing your first code review for something written by a senior member of your team is scary. As a novice programmer it’s easy to think that only beginning or intermediate developers struggle with this.

I still remember being afraid to say something obvious or stupid to someone senior to me in the code reviews I did early in my career.

Often I’d resort to safe statements like “we should add a few more comments” because I lacked confidence in my skill as a code reviewer.

So, is this something worth worrying about?

Let me start out by saying that this is actually a very common situation. You are not alone because it isn’t just novice programmers who struggle with this.

If you want to grow as a software engineer this feeling of inadequacy is something you’ll need to face (and learn to overcome!) again and again.

Here’s why: Expertise is relative.

Even as a developer experienced with a particular framework or language the time will come where you join another team to work on a different project. Then you’ll be the most inexperienced developer in regard to that project’s code base. At least for a while.

Even as a seasoned engineer or team lead you might occasionally worry about leaving clueless comments in a code review. Will you look bad to your peers? Are you going to “lose your authority” in front of a junior team member?

The only way to do it

If you want to grow your skills and experience as a developer that’s just the nature of the game. Seek out these situations! You’ll get better at dealing with them as you become more confident. This is the only way to grow.

Now where does that leave us… Should you worry about code reviewing someone more experienced than you? No, you shouldn’t. But it’s normal 😃.

This article was filed under: code-review, craftsmanship, and programming.

Related Articles:

7 ways to avoid aggravation in code reviews – Thankfully many software companies have adopted code reviews as a best practice these days. An overlooked aspect of how code reviews are conducted is how they can also affect the relationship between engineers negatively.
Should you call out code style issues in a code review? – One of my friends works at a software company where all code changes must be reviewed before they’re deployed to production – I think that’s great. However, he finds that his team spends too much time discussing code style and formatting issues in their code reviews.
Watch me do a “live” Python code review for a reader – This is a bit of an experiment – but you might find it interesting!
Python Code Review: Unplugged – Episode 2 – This is the second episode of my video code review series where I record myself giving feedback and refactoring a reader’s Python code.
Python Code Review: Unplugged – Episode 3 – In this third episode of my video code review series I take a look at a reader’s web scraping project and start adding some unit tests to it.

Latest Articles:

Interfacing Python and C: The CFFI Module – How to use Python’s built-in CFFI module for interfacing Python with native libraries as an alternative to the “ctypes” approach.
Write More Pythonic Code by Applying the Things You Already Know – There’s a mistake I frequently make when I learn new things about Python… Here’s how you can avoid this pitfall and learn something about Python’s “enumerate()” function at the same time.
Working With File I/O in Python – Learn the basics of working with files in Python. How to read from files, how to write data to them, what file seeks are, and why files should be closed.
How to Reverse a String in Python – An overview of the three main ways to reverse a Python string: “slicing”, reverse iteration, and the classic in-place reversal algorithm. Also includes performance benchmarks.
Mastering Click: Writing Advanced Python Command-Line Apps – How to improve your existing Click Python CLIs with advanced features like sub-commands, user input, parameter types, contexts, and more.
Working with Random Numbers in Python – An overview for working with randomness in Python, using only functionality built into the standard library and CPython itself.

← Browse All Articles